Up and down arrows move around during running build#828
Merged
timja merged 1 commit intojenkinsci:mainfrom Jun 12, 2025
Merged
Conversation
Member
|
I've also got #729 in draft - works well in Chrome/Edge, but not in Safari/Firefox. Safari tech preview works but with some issues. |
Contributor
chrome_ZiGnIXfYEV.mp4Indeed this "fixes" the issue with the up/down buttons, and not the flickering (but it was mentioned it wouldn't). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at a quick and dirty workaround for #823, since I wasn't able to fix it properly even with the help of an LLM, and I've run out of time to spend working on this plugin for the time being. If others find that this is helpful and the positives outweigh the negatives, great; if not, then this PR can simply be closed and I won't mind at all.
I simply removed the
--pgv-offset-bottomvariable and its associated calculation. The result isn't as visually appealing (it is at the very bottom, covering the Jenkins version), but at least it doesn't jump around. This PR doesn't seem to help the occasional flickering at all.Fixes #823
Testing done
Light testing seemed to help, at least in my environment, but additional testing would be welcome.
Submitter checklist